Closed KatieWoe closed 3 years ago
Great discovery, I was able to reproduce the problem. I tracked it back to our changes in SimInfo, and made a correction. It's now working correctly on my side. Can you please pull all and test again?
I still seem to be having this problem
@KatieWoe and I worked together, did a fresh pull and build and confirmed it is working, closing.
A couple of review items here as I was looking at https://github.com/phetsims/gravity-and-orbits/issues/386
https://github.com/phetsims/joist/blob/d95fa578c2341f20325fc5c69bd88cadfb93c558/js/SimInfo.js#L134
This should call on simInfo.info
, and I think would just return undefined right now.
Instead of duplicating these values, instead can't we just use simInfo.info.[KEY]
?
wrapperMetadata
behind Tandem.API_GENERATION` as well.I like what I see in the commit in general, but I'm wondering why we would only add into state the items that were needed for this playback. Here is the group a data that was added in this issue:
// Parts that are omitted in API generation
randomSeed: NullableIO( NumberIO ),
url: NullableIO( StringIO ),
userAgent: NullableIO( StringIO ),
window: NullableIO( StringIO ),
referrer: NullableIO( StringIO ),
flags: NullableIO( StringIO )
}
} );
Here is the putInfo
that is not added to state ever:
// globals
this.putInfo( 'language', window.navigator.language );
this.putInfo( 'checkIE11StencilSupport', Utils.checkIE11StencilSupport() );
this.putInfo( 'isWebGLSupported', Utils.isWebGLSupported );
this.putInfo( 'pixelRatio', `${window.devicePixelRatio || 1}/${backingStorePixelRatio}` );
Why wouldn't we just add all of this also to be complete? Then everything in simInfo is also in state. These would also be hidden behind Tandem.API_GENERATION
.
Here is a patch that includes all of the above review comments, @samreid if you agree would you please review or apply it.
I tested this by:
copy(phet.phetio.phetioEngine.phetioStateEngine.getState())
simInfo
has many nulls in it.Looks great, good recommendation. I applied the patch, tested and regenerated API files.
Device Dell OS Win 10 Browser Firefox Problem Description For https://github.com/phetsims/QA/issues/660 Was not fixed by fix in https://github.com/phetsims/phet-io/issues/1790. The playback wrapper does not seem to recognize the device/browser the recording was made on. When trying to play, the recording never loads and the console throws an error. Visuals