search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Restart button disabled when it shouldn't be #415

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System 12.0.1

Browser safari

Problem description While testing https://github.com/phetsims/qa/issues/744, I noticed this Gravity and Orbits issue (doesn't look like a typescript issue):

In the Studio wrapper, if you press play, pause the sim, and then launch the sim, the Restart button will be grayed out (disabled). This is also seen in the State wrapper.

Steps to reproduce In Studio:

  1. On either screen, press Play and then Pause--all of the Time Control buttons will be blue
  2. Press 'Launch Sim' button. The Restart button will be grayed out.

In State:

  1. On either screen, press Play and then Pause--all of the Time Control buttons will be blue in the upstream sim. In the downstream sim, the Restart button will be grayed out.

Visuals restartbutton

Screen Shot 2021-12-14 at 2 01 54 PM
samreid commented 2 years ago

I'll evaluate this when we return to gravity-and-orbits, unassigning for now.

samreid commented 2 years ago

The scene reset behavior under customized phet-io state was described here: https://github.com/phetsims/gravity-and-orbits/issues/343 and approved as working well.

For this issue, the state is now transmitting well:

image

But perhaps it doesn't matter because of the behavior prescribed in https://github.com/phetsims/gravity-and-orbits/issues/343 anyways. I recommend closing this issue, but @Nancy-Salpepi or @arouinfar please feel free to reopen at your discretion.