phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Unused string keys #438

Closed arouinfar closed 1 year ago

arouinfar commented 2 years ago

For #440

When reviewing the strings in Studio, I realized that there are two unused string keys -- earthDayStringProperty & earthMinuteStringProperty. These are both singular versions of the timeCounter string, however, only the plural version is ever used in the sim. image image

@samreid can you confirm if these string keys are being used somewhere in the sim? If not, can we get rid of them?

samreid commented 2 years ago

I fixed this code and it should now be using the singular strings.

image

@arouinfar can you please review?

arouinfar commented 2 years ago

Thanks @samreid. Looks good in master, but not in rc.1, so tagging for cherry-picking.

samreid commented 2 years ago

Needed for https://github.com/phetsims/qa/issues/841

Nancy-Salpepi commented 2 years ago

The singular strings have been added to RC.3. Keeping this issue open because of https://github.com/phetsims/gravity-and-orbits/issues/463.

samreid commented 2 years ago

We pushed a fix in https://github.com/phetsims/gravity-and-orbits/issues/463 and @marlitas and I confirmed the strings are correctly omitted. Leaving open for verification in RC after cherry-picking the commits from #463

samreid commented 1 year ago

Please close after verifying.

KatieWoe commented 1 year ago

This seems to be broken again in https://github.com/phetsims/qa/issues/850 notfixed2 notfixed

Nancy-Salpepi commented 1 year ago

@KatieWoe they decided to always go back to always plural because of https://github.com/phetsims/gravity-and-orbits/issues/463

samreid commented 1 year ago

From discussion with @KatieWoe

image
KatieWoe commented 1 year ago

Closing. Looks ok in RC 4