phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Return Objects button needs a maxWidth #439

Closed arouinfar closed 2 years ago

arouinfar commented 2 years ago

For #440

@samreid the Return Objects button doesn't have a maxWidth, as revealed by editing the returnObjectsStringProperty.

image.

This problem exists in the latest published version of the sim, but stringTest=long isn't long enough to reveal the layout issues, so it's flown under the radar for a while now.

samreid commented 2 years ago

Fixed and ready for review, thanks.

arouinfar commented 2 years ago

@samreid this looks fixed in master, but I'm not seeing the change in rc.1. Seems like something that will need cherry-picking.

image
samreid commented 2 years ago

Needed for https://github.com/phetsims/qa/issues/841

Nancy-Salpepi commented 2 years ago

Return objects button has a max width in RC.3

Screen Shot 2022-10-06 at 1 38 28 PM

Closing