search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Design of Restart button doesn't match other buttons #447

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

For https://github.com/phetsims/qa/issues/838 The restart button has a light gray outline around each component that isn't present in the other buttons. This inconsistency is also in the published version.

Screen Shot 2022-09-27 at 5 26 00 PM
arouinfar commented 1 year ago

Thanks @Nancy-Salpepi.

@samreid can you remove the stroke around the icon on the restart button? If not, let's at least make the stroke black so the icon looks more consistent with the other buttons.

samreid commented 1 year ago

This common code component is also used in ~Wave on a String~, ~Collision Lab~ and My Solar System. Should it be changed for all occurrences? If not, what should the default be?

arouinfar commented 1 year ago

@samreid the stroke appearance should match the icons on the PlayPauseButton and StepForwardButton. The change can apply universally to all sims.

zepumph commented 1 year ago

@samreid and I reworked the design, removing the grey stroke and updating the icon to look more like the other play/pause icons.

My solar system: image

Gravity and orbits: image

We also glanced at https://fontawesome.com/icons/backward-fast?s=solid&f=sharp for inspiration.

Anything else here @arouinfar?

arouinfar commented 1 year ago

Looks great, thanks @zepumph @samreid.

Nancy-Salpepi commented 1 year ago

Looks perfect in master and in 1.6.0-rc.3. Closing!