search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Listed elements can cause studio to crash #453

Closed KatieWoe closed 2 years ago

KatieWoe commented 2 years ago

For https://github.com/phetsims/qa/issues/838. The PhET-iO guide discusses the different preference elements and notes that not all are supported. However, they are in the tree, and trying to use them will cause a crash. Some of these elements may be listed specifically in the document, even though using them causes a crash and reload of studio. gravityAndOrbits.general.view.audioManager.audioEnabledProperty is an example for this sim. mentionsound

zepumph commented 2 years ago

Right! We should not crash if we don't support sound. Fixed above with @samreid and ready for cherry pick. We also changed manually all other preferences Properties and didn't encounter errors.

KatieWoe commented 2 years ago

This seems fixed in RC3