Closed Nancy-Salpepi closed 1 year ago
@arouinfar how do you want to address this? Should the text be left aligned? Do you just want it to say "1 Earth Days"? I'm not sure of a robust way to make sure the "1 Earth day" has the same left coordinate as "2 Earth days". Keep in mind our solution needs to be robust against locale changes and phet-io text customization.
@samreid I am fine with always using the plural Days/Minutes to avoid the jumpy behavior. Keep in mind that if we get rid of the singular forms, we should get rid of their string keys in #438.
Fixed and ready for cherry-picking.
Please close after verifying.
Looks good in 1.6.0-rc.4. Closing.
Test device MacBook Air (m1 chip)
Operating System macOS 12.6
Browser safari 16.0
Problem description For https://github.com/phetsims/qa/issues/841, I noticed that the grammar was fixed for the time displayed (1 earth day instead of days or 1 earth minute instead of minutes) between RC.2 and RC.3. This makes the time look a little jumpy when you first press Play. I was wondering if there is anything that can be done to prevent the entire time from shifting when an 's' is added/removed?
Visuals
https://user-images.githubusercontent.com/87318828/194378174-9e3d4ce4-73ff-44ca-b950-474d714c229b.mp4