search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

1.6: Unexpected token: export in record wrapper with ?localFile #480

Open samreid opened 1 year ago

samreid commented 1 year ago

Gravity and Orbits 1.6 is affected by https://github.com/phetsims/ph-scale/issues/265.

@kathy-phet said:

@samreid - Does this fix need an issue in GAO, to track as a potential MR or republish? e.g. is this bug in GAO?

I replied:

This bug occurs in Gravity and Orbits but I do not think it warrants an eager maintenance release. I don't think we have documented the localFile query parameter for client usage--it is more for our own team testing.

@kathy-phet said:

That’s ok, but can you make a tracking issue in GAO so we can track it.

If we decide this is worth the time to fix, there is a commit in https://github.com/phetsims/ph-scale/issues/265 which can be cherry-picked.

This is not a problem in master.