search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

Migration is failing CT with and optionsDialog #484

Closed samreid closed 1 year ago

samreid commented 1 year ago

Migration rules:

Assertion failed: These phetioIDs are not found in the new API. Either they were renamed incorrectly or were not migrated at all:
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.title.visibleProperty
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.title.stringProperty
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.content.projectorModeCheckbox.property
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.content.projectorModeCheckbox.visibleProperty
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.content.projectorModeCheckbox.enabledProperty
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.visibleProperty
gravityAndOrbits.general.view.navigationBar.phetButton.phetMenu.optionsDialogCapsule.optionsDialog.isShowingProperty

Check if other sims have this problem

samreid commented 1 year ago

We have something similar in molecule polarity.

samreid commented 1 year ago

https://github.com/phetsims/phet-io-sim-specific/blob/52d32a50f2c84a1e63c80889743afe5bdad636ae/repos/molecule-polarity/js/molecule-polarity-migration-rules.ts#L75-L80

zepumph commented 1 year ago

https://github.com/phetsims/gravity-and-orbits/issues/483 https://github.com/phetsims/phet-io/issues/1960

zepumph commented 1 year ago

In ph-scale for this problem we decided that we only need to delete all these tandems:

https://github.com/phetsims/phet-io-sim-specific/blob/d3c6650ee61bde9a51277754dc3be9a0b5b5778f/repos/molecule-polarity/js/molecule-polarity-migration-rules.ts#L75-L80