search

phetsims / gravity-and-orbits

"Gravity And Orbits" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
12 stars 6 forks source link

PhET-iO Migration error: missingStringPhetioElements #485

Closed zepumph closed 10 months ago

zepumph commented 10 months ago

This just started showing up on CT. I'm unsure why.

{
  "missingStringPhetioElements": [ 
  "gravityAndOrbits.general.model.strings.sceneryPhet.keyboardHelpDialog.grabOrReleaseHeadingPatternStringProperty",
  "gravityAndOrbits.general.model.strings.sceneryPhet.keyboardHelpDialog.grabOrReleaseLabelPatternStringProperty"
]
}

I noted this: https://github.com/phetsims/phet-io/issues/1877#issuecomment-1850679388 though I don't think we can actually change anything in that department without rewriting our "used strings" algorithm (currently a regex on build).

For now I will silence because it doesn't matter, but I'm just so confused how it broke, and I can't find a paper trail. I see no changes to joist/scenery-phet/gao in the last few weeks that look suspicious at all.

zepumph commented 10 months ago

@samreid can you help me understand or track down what caused this API change? I'm totally stumped.

zepumph commented 10 months ago

Ahh goodness, this was actually just a regression from a change I made Friday. I'll revert. Sorry to bother. See https://github.com/phetsims/joist/issues/946#issuecomment-1850955085 for the fix.