search

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.
GNU General Public License v3.0
3 stars 4 forks source link

(Voicing) Distance issue - only moved sphere updates its distance value #283

Closed terracoda closed 3 years ago

terracoda commented 3 years ago

I'm reviewing the version to be used in the next survey.

Both spheres' distance value needs to update when one sphere is moved, so that the next interaction with the other sphere provides the correct distance value on focus, click, tap, etc.

terracoda commented 3 years ago

This is an issue for all inputs.

jessegreenberg commented 3 years ago

Should be fixed in the above commit.

jessegreenberg commented 3 years ago

This should be fixed in this version, @terracoda can you please review? https://phet-dev.colorado.edu/html/gravity-force-lab-basics/1.1.0-dev.32/phet/gravity-force-lab-basics_en_phet.html?voicingSurvey=true

terracoda commented 3 years ago

This is good, except when you switch between distance checked and not checked. You need to move the spheres before you hear the new mode.

Can you fix that, too. The distance is updating. You just need to update the description mode (kilometers or qualitative distance) when the checkbox gets checked.

terracoda commented 3 years ago

If you can't fix this before survey time, it's not a show stopper. The information is not incorrect, it just isn't in the right mode.

jessegreenberg commented 3 years ago

This has been resolved, and I checked with @terracoda over slack who confirmed that the problem was fixed. Closing this issue.