search

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.
GNU General Public License v3.0
3 stars 4 forks source link

(Voicing) Voice does not match text in Keyboard Shortcuts menu #298

Closed stemilymill closed 2 years ago

stemilymill commented 3 years ago

https://github.com/phetsims/qa/issues/702 Win10 Firefox

Voicing reads the heading of the "Change Mass" section of the Keyboard Shortcuts menu as "Change Massachusetts"

There is also no pause in between this utterance and the next.

change mass reads change massachussetts

jessegreenberg commented 3 years ago

Thanks for making an issue, this is kind of funny. But certainly not what we want. I was able to see this in Firefox as well. There isn't a way to change the voicing interpretation of the string. I am not sure why Voicing is interpreting "Massachusetts" for the bold and not for other strings. "Change Mass" label next to the arrow keys is read correctly by speech synthesis.

jessegreenberg commented 3 years ago

@terracoda suggested that we make sure there is no punctuation that could trigger this. @emily-phet suggested to see what happens when we do not capitalize the "M".

stemilymill commented 3 years ago

This is kind of unrelated but I don't know who to tell separately- the "Change Mass" label next to the arrow keys should not have "Mass" capitalized, in order to match the rest of the dialog.

jessegreenberg commented 3 years ago

Thanks @stemilymill , Ill make a new issue for that.

jessegreenberg commented 3 years ago

It is broken up into sentences for Voicing. So It looks like "Change Mass." which I could see being interpreted as an abbreviation for the state. image

jessegreenberg commented 3 years ago

Yes, changing to a comma fixes this.

jessegreenberg commented 3 years ago

Change committed and cherry-picked to the 1.1 SHAs.

terracoda commented 3 years ago

Good catch @jessegreenberg. We'll have to keep this capitalization and punctuation in mind for auditory description displays :-)

KatieWoe commented 2 years ago

Looks ok on Win 11 Firefox+NVDA