search

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.
GNU General Public License v3.0
3 stars 4 forks source link

Recent improvements to highlights should be applied to GFL:B 1.1 #314

Closed jessegreenberg closed 2 years ago

jessegreenberg commented 2 years ago

The solution for https://github.com/phetsims/balloons-and-static-electricity/issues/541 should be cherry-picked into the 1.1 release of GFL:B as well.

jessegreenberg commented 2 years ago

This is the change to bring into the gravity-force-lab-basics-1.1 joist branch: https://github.com/phetsims/joist/commit/b37d89bd1ded0e9c6de6ce66cbfa9fcf2be65b14

jessegreenberg commented 2 years ago

Along with https://github.com/phetsims/scenery/commit/3581cded14ce45e63fa1734b5b0c77e626562c46

jessegreenberg commented 2 years ago

These have been brought into the gravity-force-lab-basics-1.1 branch. This wasn't caught in this sim but should be verified as working correctly in the next RC.

jessegreenberg commented 2 years ago

This issue is to verify that the issue found by @Nancy-Salpepi in https://github.com/phetsims/balloons-and-static-electricity/issues/541 has been moved into this sim as well. In that issue it was noticed that when focus is in the sim the "Interactive Highlights" would never appear.

To verify that this is working correctly, please make sure that a small amount of mouse movement hides the focus highlight and makes that "Interactive Highlights" appear from mouse/touch movement.

Also, please make sure that https://github.com/phetsims/balloons-and-static-electricity/issues/541#issuecomment-944658911 does not happen in this sim either.

Nancy-Salpepi commented 2 years ago

This looks good. I'm not seeing https://github.com/phetsims/balloons-and-static-electricity/issues/541#issuecomment-944658911 anymore either.

@jessegreenberg I just have one question. When focus highlights and interactive highlights are on the same object, if I use my mouse to move that object, should focus highlights start back from the beginning when the tab key is used or move forward to the next object? Currently, it moves to the next object. focushighlight

jessegreenberg commented 2 years ago

Hey @Nancy-Salpepi - In this case it should move to the next object. The focus stays where it was, only the focus highlight disappears. I think the video capture is correct.

Nancy-Salpepi commented 2 years ago

OK thanks @jessegreenberg. I just want to confirm that in every other instance, the focus highlight returns to "the beginning" (Mass 1 object) when switching from mouse to touch?

jessegreenberg commented 2 years ago

Ah, I see. Yes, it is a little different once you actually click into the sim. Basically, if you click on something that has focus, focus will stay where it is and pressing tab will move on to the next thing. If you click on anywhere else, focus will start over from the top of the page. It is not ideal, but what you described is what we would expect currently. There is a plan to improve it in https://github.com/phetsims/joist/issues/750, but I am not sure when that work will be done.

Nancy-Salpepi commented 2 years ago

Awesome. Thanks @jessegreenberg. Closing this issue!