search

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.
GNU General Public License v3.0
3 stars 4 forks source link

MassControl voicing should run on Voicing trait in NumberPicker #320

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

I made this commit over in https://github.com/phetsims/scenery-phet/issues/725, which @terracoda used to report that context responses were lost in https://github.com/phetsims/scenery-phet/issues/725#issuecomment-1059757907.

I think we should have all voicing covered by the trait.

zepumph commented 2 years ago

@jessegreenberg, can you take a look, does this seem acceptable to you?

terracoda commented 2 years ago

The Mass number pickers in GFLB and the Left and Right Value number pickers in RaP are working well, and seem to be working in the exact same way as well.

The reading blocks are different, but that is intentional. The Mass Control reading blocks in GFLB are not keyboard accessible (this is intentional) whereas the Current Challenge reading block is keyboard accessible (this is intentional).

terracoda commented 2 years ago

Leaving open for @jessegreenberg.

terracoda commented 2 years ago

My comment was supposed to go in the related phetsims/scenery-phet#725 issue, copying it over there.

jessegreenberg commented 2 years ago

Code changes look good and @terracoda confirmed that the behavior is good, closing.