search

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.
GNU General Public License v3.0
3 stars 4 forks source link

No longer hearing voiced context responses on checkboxes #324

Closed terracoda closed 1 year ago

terracoda commented 2 years ago

I think something happened in Voicing common code. I am no longer hearing context responses on the checkboxes.

terracoda commented 2 years ago

Maybe this is a known issue?

terracoda commented 1 year ago

I would not like this bug to accidentally be published. Is it appropriate to add blocks simulation publication label?

jessegreenberg commented 1 year ago

Yes, that is appropriate. Thanks!

jessegreenberg commented 1 year ago

I am guessing that when common code support was added to Checkbox for Voicing, these usages were not updated. So the common code Voicing (not used and empty) is overriding the sim specific implementation.

jessegreenberg commented 1 year ago

We have a whole inner class that implements Voicing on a checkbox, that can be removed now that it is built into the main component.

jessegreenberg commented 1 year ago

Fixed with the above commit.