Use `ResetAllButton.isResettingAllProperty` to mute sound in `MassSoundGenerator`

phetsims / gravity-force-lab-basics

A simplified version of PhET's "Gravity Force Lab" simulation, intended for use with younger students.

GNU General Public License v3.0

3 stars 4 forks source link

Use `ResetAllButton.isResettingAllProperty` to mute sound in `MassSoundGenerator` #328

Closed jbphet closed 5 months ago

jbphet commented 5 months ago

In https://github.com/phetsims/tambo/issues/190 a more globally available flag was created that can be used to determine if a "reset all" action is in progress. This could be used in MassSoundGenerator to mute sound generation during reset.

jbphet commented 5 months ago

Changes made. Assigning to @zepumph for review, as he is listed as the responsible dev for this sim.

jbphet commented 5 months ago

Note that this also affects gravity-force-lab, but it doesn't seem like it's worth a separate issue. Both should be reviewed.

zepumph commented 5 months ago

Looks great, thanks