search

phetsims / gravity-force-lab

"Gravity Force Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/gravity-force-lab
GNU General Public License v3.0
4 stars 6 forks source link

Consider converting to default layoutBounds before PhET-iO publication #288

Closed pixelzoom closed 11 months ago

pixelzoom commented 1 year ago

This sim currently uses non-default layoutBounds. In GravityForceLabScreenView:

      layoutBounds: new Bounds2( 0, 0, 768, 464 ),

Per https://github.com/phetsims/phet-io/issues/1939... layoutBounds should not be changed for published PhET-iO sims because doing so may disrupt client customizations. So evaluate whether to change layoutBounds before publishing a PhET-iO version.

If you decide not to change layoutBounds, document why in GravityForceLabScreenView, and refer to this issue.

pixelzoom commented 1 year ago

Also noting that this constant is duplicated in GFLBScreenView:

      layoutBounds: new Bounds2( 0, 0, 768, 464 ),

That's bad news if they are not both changed at the same time.

marlitas commented 11 months ago

Closing per dev meeting request 12/7/23.