search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Some of the sound files are larger than they probably need to be #198

Open jbphet opened 3 years ago

jbphet commented 3 years ago

While working on the soundboard (see https://github.com/phetsims/phetmarks/issues/45), I noticed that the slow-motion rotation sounds are very long. I suspected that this means that the files are also quite large, and indeed they are. According to Windows Explorer, the size for both rotation-counterclockwise-slow-motion.mp3 and rotation-clockwise-slow-motion.mp3 is is 303 KB. The lengths of these loops could probably be reduced quite a bit without compromising the user experience. This would reduce the size of the download for this sim, as well as the startup time.

I'm thinking I should go ahead and do this, since we are going to be consolidating this code into the greenhouse-effect fairly soon.

jbphet commented 3 years ago

Note to self: Remember to benchmark the sim size and startup time before and after making the changes to these files.

jbphet commented 2 years ago

Transferred this issue from molecules-and-light to greenhouse-effect, since that's where the sound files now reside.

I'm also going to mark this as "blocks-publication", since this should be addressed before the next publication of the Molecules and Light sim or any version of Greenhouse Effect that includes these sounds.

zepumph commented 2 years ago

I would recommend this as a "blocks-sim-publication", and creating a "pointer" issue if needed in Molecules and Light because otherwise every dev will see this issue when going to publish any sim (like I just did for getting ready for Friction and Ratio and Proportion).

jbphet commented 1 year ago

To be clear, this blocks the publication of Molecules and Light, but not Greenhouse Effect, since the latter doesn't use the sounds in question.

jbphet commented 1 year ago

There isn't much value in working on this until we are either adding the "Micro" screen to the Greenhouse Effect or we need to republish Molecules and Light from the main branch. I'm going to unassign and defer for now. This issue should be "reactivated" when work either of these two efforts begins.