Closed arouinfar closed 1 year ago
@jbphet I added the data for the greenhouse gas concentrations to the design doc. Over to you to update the readouts for each time period.
I've added in the data that @arouinfar supplied, and we reviewed it in the context of the sim in this week's design meeting, and here are the follow ups:
@arouinfar - The relative humidity portion has been removed. I'm assigning this to you for follow-up on whether we're good to go with that change.
In a recent design meeting, it was brought up that using decimal values of ppm, as we do now, is unusual. It is more common to use ppb. Should we do that here? If we do, should we have a little info dialog like we do in other sims (e.g. Fourier).
Screenshot of current indicator:
@arouinfar said during today's design meeting to go ahead with ppb for the upcoming prototype release. We won't worry about having an info dialog for now and will follow up on whether it's needed for the full release later.
I've changed the designated compounds to use ppb. Unassigning myself, @arouinfar can follow up on whether we want to add an info dialog.
Thanks @jbphet. The readout looks good in master.
Mark provided this source to explain water vapor's relationship to the greenhouse effect: https://climate.nasa.gov/ask-nasa-climate/3143/steamy-relationships-how-atmospheric-water-vapor-amplifies-earths-greenhouse-effect/
We decided to remove the humidity readout for a few reasons:
I've added a note to the Teacher Tips issue, so we can close this issue.
@arouinfar I know this issue is closed, but I would like to vote for an info button in the full release. In my experience, HS students tend to look at numbers and not units (although they should). They just think biggest number = highest concentration (which is incorrect in this case).
Reopening based on what @Nancy-Salpepi said in the comment just above. @arouinfar - does her comment change your thinking on this, or do you still feel like the teacher tips update will cover it?
The open question is whether an Info dialog is needed here. @arouinfar?
Thanks for the feedback @Nancy-Salpepi. We are using the standard units for these measurements, but I agree, students don't always read the units. That said, I think an info dialog explaining ppb vs. ppm is a bit heavy-handed and adds additional work for Interactive Description and PhET-iO. I would prefer to leave this as-is, and if we receive teacher feedback that students have issues with this, we can reconsider and include it in a future release.
Looks like 2020 data appears, but 1950, 1750, and Ice Age data needs to be added. This should be done before publishing a prototype in #220. Self-assigning to confirm data.