phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

How should dynamic locale and description features interact? #299

Open pixelzoom opened 1 year ago

pixelzoom commented 1 year ago

This issue came out of a discussion that @jbphet and I had in https://github.com/phetsims/greenhouse-effect/issues/288.

We need to confirm that the dynamic locale and description features work well together. Because we only have English descriptions, we should verify that when we switch between English and some other locale, the features are "well behaved".

For example, if we switch from English to Spanish, we probably don't want descriptions to continue to be read in English. And if we switch from Spanish to English, do we want descriptions to be read?

Since we're not quite sure what "well behaved" means, let's start there. @arouinfar thoughts? Want to discuss with @jbphet and me?

jbphet commented 1 year ago

A general issue on the interaction between dynamic locale and description has been logged, see https://github.com/phetsims/scenery/issues/1563.

arouinfar commented 1 year ago

I commented in https://github.com/phetsims/scenery/issues/1563, but the main takeaway for Greenhouse Effect is that the Localization tab should be screen reader accessible. The other tabs of the Preferences dialog already support description.

pixelzoom commented 1 year ago

Conclusions are in https://github.com/phetsims/scenery/issues/1563#issuecomment-1593348204.

Work required to unblock Greenhouse Effect 1.2 publication is in https://github.com/phetsims/joist/issues/930.

pixelzoom commented 1 year ago

Great to see that https://github.com/phetsims/joist/issues/930 has been addressed.

@jessegreenberg can you please summarize here how QA should test this during Greenhouse dev testing?

pixelzoom commented 1 year ago

Ping @jessegreenberg -- see https://github.com/phetsims/greenhouse-effect/issues/299#issuecomment-1597416420

jessegreenberg commented 1 year ago

I met with @KatieWoe and @Nancy-Salpepi last week to discuss testing Preferences for screen reader accessibility so they are aware. Also, the Localization tab was tested for screen reader access in a recent dev test https://github.com/phetsims/qa/issues/958