Change requests for temperatureUnitsSelector element

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 4 forks source link

Change requests for temperatureUnitsSelector element #318

Closed pixelzoom closed 12 months ago

pixelzoom commented 1 year ago

This came up in a discussion with @arouinfar. I volunteered to create the GitHub issue and will do the work.

The Layer Model screen has this control:

Relevant part of the Studio tree:

Change requests:

[x] rename temperatureUnitsSelector to temperatureUnitsControl, to be consistent with naming convention in https://github.com/phetsims/greenhouse-effect/issues/311
[x] feature temperatureUnitsControl.visibleProperty
[x] uninstrument temperatureUnitsRadioButtonGroup.visibileProperty

pixelzoom commented 1 year ago

Ready for review by temperatureUnitsControl by @arouinfar. Note that I did not feature temperatureUnitsControl because we did not feature the *Control elements added in #311. Let me know if there are additional changes needed, feel free to close if OK.

pixelzoom commented 12 months ago

We have a similar case in the Preferences dialog:

... with similar change requests:

[x] rename defaultTemperatureUnitsSelector to defaultTemperatureUnitsControl
[x] feature defaultTemperatureUnitsControl.visibleProperty
[x] uninstrument defaultTemperatureUnitsRadioButtonGroup.visibileProperty

pixelzoom commented 12 months ago

@arouinfar ready for review.

arouinfar commented 12 months ago

Thanks @pixelzoom. These changes all look great. The temperatureUnitsSelector appeared in examples.md, so I updated it to temperatureUnitsControl in the above commit. Closing.