Closed pixelzoom closed 12 months ago
Thanks @pixelzoom. I vote for option (2). Naming this control has been tricky. I would prefer to keep it "Show Surface Temperature" in the sim, and update the class and tandem names to match.
@arouinfar please review, close if OK.
Looks good, thanks @pixelzoom.
There's some inconsistency in the naming associated with this checkbox, and it's unfortunately exposed by PhET-iO:
It is currently implemented in class
SurfaceTemperatureCheckbox
, with stringshowSurfaceTemperatureStringProperty
, and tandem namesurfaceTemperatureCheckbox
. So the "Show" bit is sometimes there, sometimes not there.Options:
(1) Do nothing.
(2) Rename class
SurfaceTemperatureCheckbox
toShowSurfaceTemperatureCheckbox
, and tandemsurfaceTemperatureCheckbox
toshowSurfaceTemperatureCheckbox
(3) Rename
showSurfaceTemperatureStringProperty
tosurfaceTemperatureStringProperty
, change its key to "surfaceTemperature", and change its value to "Surface Temperature". (This string is not used in Molecules and Light, but might have been used in Greenhouse Effect prototype.)@arouinfar what would you like to do?