Closed jbphet closed 1 year ago
@KatieWoe and I just discussed how best to approach doing a performance test for this sim, and here's what we are currently thinking:
Worst cases for each of the three screens:
The dev version has been built and can be found at https://phet-dev.colorado.edu/html/greenhouse-effect/1.2.0-dev.1/phet/greenhouse-effect_all_phet.html.
The table for collecting the performance data is below (in the next comment). Here are some notes:
profiler
to get the performance info to show up on the screen, and use the FPS value on the far left. It will look something like this:
Device | Browser | Waves WC FPS | Waves WC Usable? | Photons WC FPS | Photons WC Usable? | Layers WC FPS | Layers WC Usable? |
---|---|---|---|---|---|---|---|
@jbphet's Dell Precision | Chrome | 60 | yes | 60 | yes | 60 | yes |
Device X | ? | ? | ? | ? | ? | ? | ? |
Assigning to @KatieWoe and @Nancy-Salpepi for the next steps.
Device | Browser | Waves WC FPS | Waves WC Usable? | Photons WC FPS | Photons WC Usable? | Layers WC FPS | Layers WC Usable? |
---|---|---|---|---|---|---|---|
@jbphet's Dell Precision | Chrome | 60 | yes | 60 | yes | 60 | yes |
macbook air | safari | 60 | yes | 60 | yes | 60 | yes |
2003 mac desktop | safari | 60 | yes | 60 | yes | 60 | yes |
iPad (9th gen) | safari | 30 | yes | 30 | yes | 30 | yes |
chromebook | chrome | *20 | yes | *14 | yes | *23 | yes |
Device | Browser | Waves WC FPS | Waves WC Usable? | Photons WC FPS | Photons WC Usable? | Layers WC FPS | Layers WC Usable? |
---|---|---|---|---|---|---|---|
@jbphet's Dell Precision | Chrome | 60 | yes | 60 | yes | 60 | yes |
Samsung Win 11 | Firefox | 60 | yes | 60 | yes | 50-60 | yes |
Chromebook | Chrome | 40-50 | yes | 45-55 | yes | 30 | yes |
iPad Pro | Safari | 60 | yes | 55 | yes | 35 | yes |
Between @Nancy-Salpepi and I, I think think this is enough data. @jbphet back to you
Thanks QA team!
Based on the data above, it looks like QA found the worst case situations for each of the three screens usable on all test devices. @arouinfar - as the designer, I think it is up to you to ultimately sign off on this, though you're welcome to bring in @kathy-phet if you like.
Thanks @Nancy-Salpepi @KatieWoe!
Performance is generally looking good, with lower-performing devices still being acceptable. I'm happy to close @jbphet.
As part of the code review process for the release of the phet-io version of this sim, performance should be reviewed and approved by the designer(s).