phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

IE workaround in PhotonEmissionSoundGenerator.ts #333

Closed pixelzoom closed 11 months ago

pixelzoom commented 11 months ago

For code review https://github.com/phetsims/greenhouse-effect/issues/331 ...

  • [ ] IE is no longer supported. With that in mind remove IE-specific workarounds

I see these 2 workarounds in PhotonEmissionSoundGenerator.ts:

    // Note - can't use initialization constructor for Map due to lack of support in IE.
    const photonInitialEmissionSoundPlayers = new Map();
...
    // Note - can't use initialization constructor for Map due to lack of support in IE.
    const photonEmissionFromMoleculeSoundPlayers = new Map();

I think it's fine the way it is, but wanted to point it out in case @jbphet wants to initialize the Map when it's instantiated.

jbphet commented 11 months ago

Workaround removed, and the code now uses the Map constructor to set initial values. Closing.