search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Some values can't be customized using their associated model property #351

Closed Nancy-Salpepi closed 10 months ago

Nancy-Salpepi commented 10 months ago

For https://github.com/phetsims/qa/issues/970

In the examples.md, under Control Sunlight and Infrared Properties, it says that values can be customized using the associated model property, but greenhouseEffect.layerModelScreen.model.groundLayer.albedoProperty and greenhouseEffect.layerModelScreen.model.atmosphereLayers.numberOfActiveAtmosphereLayersProperty are read only and can only be customized through direct interaction with the sim. Is that OK?

arouinfar commented 10 months ago

Thanks for reporting @Nancy-Salpepi. These properties appear on all screens, which is probably why they are read-only. It would be problematic for clients to change the albedoProperty of the ground on the Waves screen, for example.

@jbphet can you make these properties phetioReadOnly: false on the Layer Model screen only? These properties power UI controls on that screen, and it's reasonable to expect that clients may need to set them with the API.

jbphet commented 10 months ago

@arouinfar - I've committed changes for this, please check it over and assign back to me with your assessment.

arouinfar commented 10 months ago

Things look great on main @jbphet. As requested, back to you.

jbphet commented 10 months ago

Cool. I'll unassign and have it verified by QA in the next round of testing.

jbphet commented 10 months ago

QA - Feel free to close once verified.

Nancy-Salpepi commented 10 months ago

The properties are now phetioReadOnly: false and customizable 🙂.