Odd font for Celsius and Fahrenheit with Win10 + Chrome

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 4 forks source link

Odd font for Celsius and Fahrenheit with Win10 + Chrome #354

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

For https://github.com/phetsims/qa/issues/970, the font for Celsius and Fahrenheit is different than Kelvin in Win + chrome. I don't see this with mac + chrome/safari or win + FF.

Win10 + Chrome:

units1 units2

Mac + Chrome:

jbphet commented 1 year ago

I believe this is due to the fact that I'm using single unicode characters for "degrees Celsius" and "degrees Fahrenheit". I could change this to be two separate characters, since I just checked and there is a separate character for degrees. It may not look quite as compact, but will be more consistent.

jbphet commented 1 year ago

I went ahead and changed this on the main branch, and I can see the difference on my machine. Below are some screenshots.

Before:

After:

jbphet commented 1 year ago

I just reviewed this with @arouinfar over Zoom, and she and I agree that this seems like an improvement. I'll need to change it in the previously submitted translation files too.

jbphet commented 1 year ago

This has been fixed for all existing translations as of this moment.

[ ] Note to self: Check for single-char versions of these units in translations just before publishing, since some could sneak in between now and then.

jbphet commented 1 year ago

QA - Feel free to close once verified.

KatieWoe commented 1 year ago

Things looked good on Win 11 Chrome and Firefox. Will reopen if anything shows up in other platforms.