search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Add "Toggle Checkboxes" to Keyboard Shortcuts Dialog #355

Closed Nancy-Salpepi closed 10 months ago

Nancy-Salpepi commented 10 months ago

Test device MacBook Air M1 chip

Operating System 13.5

Browser Safari 16.6

Problem description For https://github.com/phetsims/qa/issues/973, the Keyboard Shortcuts Dialog should have "Toggle checkboxes" included in it. This is a currently a manual step that needs to be taken by the developer (see Slack conversion below).

From Slack: Amy Rouinfar @jessegreenberg is options.withCheckboxContent something a sim dev needs to be in charge of? Or is an automatic thing handled by common code? (edited)

Jesse Greenberg It is a manual step now, there currently isn't a way to auto detect if the sim is using a checkbox.

Amy Rouinfar Thanks @jessegreenberg! @Nancy Salpepi can you include this in the Greenhouse issue, please?

Jesse Greenberg

Is that something that should always be included for sims that have keyboard nav + checkboxes?

Yes, I believe so!

Visuals Here is what it looks like in Quadrilateral as a result of https://github.com/phetsims/quadrilateral/issues/431:

Screenshot 2023-08-23 at 2 21 32 PM
jbphet commented 10 months ago

Added to main and cherry-picked into the 1.2 branch. Note that this only appears in the keyboard help dialogs for the sim screens and not for the home screen since there are no checkboxes there.

jbphet commented 10 months ago

QA - feel free to close when verified.

Nancy-Salpepi commented 10 months ago

"Toggle checkboxes" has been added to rc.2. Closing.