search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Add instructions to change default temp when limiting options in listBox #357

Closed Nancy-Salpepi closed 10 months ago

Nancy-Salpepi commented 10 months ago

As we discussed on zoom, when removing a temperature unit from the listBox, it is important to tell instructional designers to make sure that unit is not set as the default in the Preferences Menu.

For example, if I set greenhouseEffect.wavesScreen.view.observationWindow.surfaceThermometer.comboBox.listBox.celsiusItem.visibleProperty to false, but don't change the default units, pressing reset all will result in the ℃ unit being displayed on Reset All.

Nancy-Salpepi commented 10 months ago

tagging https://github.com/phetsims/qa/issues/973

arouinfar commented 10 months ago

Thanks @Nancy-Salpepi. I updated the examples doc in the above commit.

@jbphet this will need to be cherry-picked into the release branch.

jbphet commented 10 months ago

I created the branch, cherry picked the commit, and updated the dependencies. We should be good to go on this. I'll have QA validate in the next round of testing.

jbphet commented 10 months ago

QA - feel free to close when verified.

Nancy-Salpepi commented 10 months ago

Instructions have been added to rc.2. Closing.