search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Update phrases that describe IR interaction with ground and atmosphere for the Photons screen #371

Closed jbphet closed 7 months ago

jbphet commented 7 months ago

As of this writing the Photons screen is describing the IR behavior using the terminology that was used for the Waves screen. This needs to be updated for the Photons screen. The spec describes the needed changes.

Parent issue for this is #368.

jbphet commented 7 months ago

This has been implemented. @arouinfar - please review the behavior on master.

arouinfar commented 7 months ago

@jbphet I'm not 100% sure what aspect of the description you would like me to verify. I believe it's the couplet related to infrared radiation/photons that's triggered when the greenhouse gas concentration changes. The behavior on main looks correct to me.

Waves Screen: {{More/Less}} infrared {{radiation}} redirecting back to surface. {{More/Less}} infrared {{radiation}} emitting from surface.

Photons Screen: {{More/Fewer}} infrared {{photons}} redirecting back to surface. {{More/Fewer}} infrared {{photons}} emitting from surface.

Is there anything else that needs to be reviewed for this issue @jbphet?

jbphet commented 7 months ago

Sounds good, closing.