Flux Meter altitude aria-valuetext is missing

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

4 stars 4 forks source link

Flux Meter altitude aria-valuetext is missing #379

Closed arouinfar closed 9 months ago

arouinfar commented 9 months ago

Discovered on main. Related to #374 and #368

The flux meter altitude is currently being output as a raw, unitless number in the a11y view:

According to the spec, the aria-valuetext should be of the form:

Photons screen: {{qualtiative value}} {{above/below cloud}}, e.g. high altitude above cloud
Layer Model screen: {{qualtitave value}} {{position relative to layers}}, e.g. near surface below layer 1

This appears to be a regression, as the behavior was previously correct.

arouinfar commented 9 months ago

Actually, this seems to be a bigger problem. The Greenhouse Gas Concentration slider also lacks the proper aria-valuetext. It should provide the concentration on a qualitative scale, not the raw value.

jessegreenberg commented 9 months ago

This regression is the same as #367, a common code change temporarily broke all options for AccessibleValueHandler/AccessibleSlider. It is fixed in main @arouinfar and thank you for finding this!

arouinfar commented 9 months ago

Thanks @jessegreenberg! Things look good on main, closing.