search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Add context response for changing temperature units when Surface Thermometer is unchecked #382

Closed arouinfar closed 5 months ago

arouinfar commented 5 months ago

Related to #374

When changing the temperature units, there is a context response that reads out the current surface temperature in the selected units. This works very well for the Waves/Photons screens where it is only possible to change the units when the thermometer is visible. However, the Layer Model Screen has separate checkboxes for the surface and atmospheric layers, so there is a global temperature units control that is always visible.

On main, changing the temperature units on the Layer Model will read out the surface temperature, even if the surface thermometer is unchecked. This seems buggy. image

We need an alternative context response for when Surface Thermometer is unchecked. Discussed with @jbphet and we'd like to go with: Temperature units {{value}}. For example, "Temperature units degrees Celsius."

Over to you @jbphet.

jbphet commented 5 months ago

Good catch @arouinfar! I've added a new description for the situation you've described. Please check it over on main and close if it fits the bill.

arouinfar commented 5 months ago

Looks good, thanks @jbphet! Closing.