search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

NVDA trying to activate a button when not focused on it stops all description #387

Closed KatieWoe closed 7 months ago

KatieWoe commented 8 months ago

Test device Samsung Operating System Win 11 Browser Firefox Problem description For https://github.com/phetsims/qa/issues/1033 If you are in the keyboard nav dialog and try to press the x button, if focus isn't on it, even if it looks like it is, all reading will stop. Pressing tab, shift tab, or arrows will give no response. Pressing space or enter again brings back normal control. Steps to reproduce

  1. With NVDA, open the keyboard nav dialog
  2. Let it start reading, at least to the tab to get started section
  3. Press space or enter, as if trying to press the button that was read out first, but you missed
  4. Try to navigate
  5. Press space or enter again

Visuals

https://github.com/phetsims/greenhouse-effect/assets/41024075/9db1738d-9f12-43e2-a51b-c74ba56a48ad

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Greenhouse Effect‬ URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.3.0-dev.3/phet/greenhouse-effect_all_phet.html Version: 1.3.0-dev.3 2024-01-23 21:58:15 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:122.0) Gecko/20100101 Firefox/122.0 Language: en-US Window: 1536x731 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 Vendor: Mozilla (ANGLE (Intel, Intel(R) HD Graphics Direct3D11 vs_5_0 ps_5_0)) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
jbphet commented 7 months ago

I agree that this seems like incorrect behavior. I'll try to set up a time to work with the a11y team to address this, since I don't have much of an idea of where to start on this.

jbphet commented 7 months ago

@jessegreenberg and I reviewed this together, and @jessegreenberg said that the behavior above is actually correct. What's happening behind the scenes is that the virtual cursor - which experienced screen reader users would know about - is moving through the keyboard dialog to allow the users to read it. In the scenario described above, the Space and Enter keys are interacting with this virtual cursor even though it looks (visually) like the close button is selected due to the highlight. I learned from @jessegreenberg that I could use the arrow keys to navigate the virtual cursor back to the close button and then successfully close the dialog using the Enter key. Apparently experienced screen reader users will know this, so it is not a problem.

I'm going to remove the "bug" label and add "won't fix" and close this one.