phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Updates to focus order and heading structure for temperature-related controls #398

Closed arouinfar closed 5 months ago

arouinfar commented 5 months ago

In #394 we added a "Temperature Units" heading to the first two screens to make it more consistent with the Layer Model Screen. However, while discussing the changes for #397 the design team realized that there was still some work to be done.

On the Layer Model Screen, the Temperature Units is housed under the Control Area, but for the Waves and Photons Screens, it's under the Play Area.

jbphet commented 5 months ago

@arouinfar and I just reviewed my attempts to implement the requests above, and the behavior is looking good. I'm not sure that my implementation was the way it should be, so I'll review with @jessegreenberg before finalizing.

For the record, @arouinfar said that if it's hard to do the "Thermometers" section in a reasonable way, she'd be okay to drop it.

jbphet commented 5 months ago

@jessegreenberg just reviewed this with me over Zoom and we decided to group the thermometer controls together into a div for improved maintainability. The overall behavior and appearance should be unchanged, but I'd like @arouinfar to take one last look at it and make sure it looks good before closing.

arouinfar commented 5 months ago

Change focus order of Temperature Units ComboBox so that it is the first item under the Control Area, between the Cloud checkbox (last item in Play Area) and the Surface Thermometer checkbox.

@jbphet looks like you did this for the Waves Screen, but not the Photons screen. Can you please apply these changes to the Photons screen as well?

The structure on the Waves Screen looks perfect image

jbphet commented 5 months ago

Oops, my bad. Glad you caught that @arouinfar. Please have a look now.

arouinfar commented 5 months ago

Looks good, closing!