search

phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Greenhouse Effect: publish 1.3 (brands=phet,phet-io) #408

Closed jbphet closed 3 months ago

jbphet commented 4 months ago

The description feature is now fully implemented for Greenhouse Effect, and a dev test was just performed. We're ready to move forward with publishing 1.3 in order to make this feature available to the public. This publication will include both the phet and phet-io brands.

jbphet commented 4 months ago

The first RC has been built and the test issue is set up, see https://github.com/phetsims/qa/issues/1086.

jbphet commented 4 months ago

I just got word from @jonathanolson over Slack that a patch is needed on the RC branch. He said that this shouldn't affect RC testing, so I don't need to rebuild the RC and restart the test process. The commit is https://github.com/phetsims/greenhouse-effect/commit/7db4a2af413a0be602fe4f3bfb873f0e8fa4bb4d, and it's related to a query param issue, so I should check for the correct behavior on the 1.3 branch before publishing.

jonathanolson commented 4 months ago

To test the patch, I'd go to a locale that isn't itself translated, but has a translated fallback locale (es_PY is something I've been using). Try ?locale=es_PY, and ensure that it loads fallback strings from es (Spanish) instead of English.

jbphet commented 3 months ago

I'm deploying the production version now, and want to note that the test @jonathanolson describes above was run and passed on the built version prior to production.

jbphet commented 3 months ago

Version 1.3.0 was published yesterday. Closing.