phetsims / greenhouse-effect

"Greenhouse Effect" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
4 stars 4 forks source link

Shift command doesn't work on Layer Model screen #409

Closed KatieWoe closed 1 month ago

KatieWoe commented 1 month ago

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/1086 When using keyboard nav to move the Flux Meter on the Layer Model screen, using shift + up/down does not move the meter in smaller steps as it should. It moves the same amount as not using shift. The shift command works properly on the Flux Meter on the Photons screen.

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Greenhouse Effect‬ URL: https://phet-dev.colorado.edu/html/greenhouse-effect/1.3.0-rc.1/phet/greenhouse-effect_all_phet.html Version: 1.3.0-rc.1 2024-05-13 19:29:11 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36 Language: en-US Window: 1536x695 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 4096 Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}
arouinfar commented 1 month ago

Good catch @KatieWoe, but in this case the difference is intentional.

The step sizes for the flux meter were specified in https://github.com/phetsims/greenhouse-effect/issues/367. For the Layer Model Screen, we chose discrete steps for two reasons. First, the flux is constant between the layers so fine adjustment is unnecessary. Second, if the probe collides with a layer, the sim will automatically bump it away. This creates a really confusing experience for screen reader users. To avoid this, we specified an array of possible positions because there wasn't a uniform step size that would avoid all layers.

@jbphet there isn't anything we need to do here, closing.