search

phetsims / griddle

Dynamic charting library built with Scenery
MIT License
2 stars 4 forks source link

Generalize ChartCursor #42

Closed jessegreenberg closed 3 years ago

jessegreenberg commented 5 years ago

Neuron has a "ChartCursor" which the user can grab and drag move back and forth through time. The same cursor is needed in energy-skate-park so I would like to generalize this component.

image

@jbphet do you have thoughts or recommendations about this since you are the author of ChartCursor?

Since this is related to the "chart" I opened this issue in griddle, which is where I think the component should live.

jessegreenberg commented 5 years ago

It seems like we could just move the cursor graphic to griddle or we could generalize more of the functionality of the cursor. If we generalize the functionality of the cursor, we probably will want to generalize portions of the time chart too since the cursor is pretty coupled with the chart. I think that would be the best way to go so I am going to look into that.

jbphet commented 5 years ago

I don't have a ton of thoughts on this, since I did it quite a while ago, but I have one idea on how to improve it. I have noticed that people tend to miss this feature, and that seems like a shame, because it's very cool and adds a lot to the sim. I think the cursor itself should highlight noticeably when the mouse goes over it so that users are more likely to notice it and try it out.

jessegreenberg commented 5 years ago

OK, that sounds good, thanks!

samreid commented 3 years ago

This was developed in griddle for Energy Skate Park, and we can port other sims to use it as necessary, closing.