search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Turn off right alignment of icons in panels. #100

Closed pixelzoom closed 2 months ago

pixelzoom commented 2 months ago

For https://github.com/phetsims/qa/issues/1102 ...

@arouinfar and I discussed the alignment of icons in the control panels.

In the published 1.0 version, icons are not right aligned. For example, in the Systems screen:

screenshot_3391

Right aligning all of the icons looks odd and introduces too much space between labels and icons, for example:

screenshot_3392

So we decided it would be best to turn off right alignment for this sim, and (for checkboxes and radio buttons) maintain a constant space between their text labels and icons, as in the 1.0 version.

pixelzoom commented 2 months ago

@arouinfar please review, close if OK.

pixelzoom commented 2 months ago

Note that we also decided to reduce the minimum content width to 150 for the top-right panel in each screen. That was implemented in https://github.com/phetsims/hookes-law/commit/083de1bc49413d9d79b45fb6729745b27e00c545, and can be tested with ?stringTest=dynamic.

arouinfar commented 2 months ago

I tested on main with stringTest=dynamic and everything looks good, closing.