search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Drag listener isn’t interrupted when switching scenes #105

Closed pixelzoom closed 1 month ago

pixelzoom commented 1 month ago

For RC test https://github.com/phetsims/qa/issues/1104 ...

In https://github.com/phetsims/qa/issues/1104#issuecomment-2226237958, @Nancy-Salpepi reported:

... on the iPad the drag listener isn’t interrupted when switching scenes. For example, on the Systems screen, while moving a slider back and forth with one finger, switching to Series and then back to Parallel will show the slider still moving back and forth.

pixelzoom commented 1 month ago

Fixed in the Systems screen by interrupting interactions with the systems when the system type (series vs parallel) is changed.

This was also a problem in the Intro screen when switching between 1 and 2 systems. Since the Intro screen animates when switching systems, it seems better to interrupt interactions with both systems, rather than to allow continued interaction with system 1 while it's moving.

Tested in 1.2.0-dev.1 on my iPad6 with Safari + iPadOS 17.51.

@Nancy-Salpepi please review. Leave open for verification in 1.1.0-rc.2.

Nancy-Salpepi commented 1 month ago

Looks good on main!

pixelzoom commented 1 month ago

Ready for verification in https://github.com/phetsims/qa/issues/1112. Please close if OK.

Nancy-Salpepi commented 1 month ago

Fixed in rc.2. Closing.