search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

sim relies on align:'right' default for Panels #42

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at IntroVisibilityControls.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new IntroVisibilityControls (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroVisibilityControls.js?bust=1472164900792:107:11)
    at new IntroView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroView.js?bust=1472164900792:39:30)
    at IntroScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/IntroScreen.js?bust=1472164900792:31:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
    at http://localhost/~cmalley/GitHub/hookes-law/js/hookes-law-main.js?bust=1472164900792:37:15
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new IntroSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSpringControls.js?bust=1472164900792:52:7)
    at new IntroSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSystemNode.js?bust=1472164900792:112:26)
    at new IntroView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroView.js?bust=1472164900792:55:23)
    at IntroScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/IntroScreen.js?bust=1472164900792:31:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new IntroSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSpringControls.js?bust=1472164900792:53:7)
    at new IntroSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSystemNode.js?bust=1472164900792:112:26)
    at new IntroView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroView.js?bust=1472164900792:55:23)
    at IntroScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/IntroScreen.js?bust=1472164900792:31:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new IntroSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSpringControls.js?bust=1472164900792:52:7)
    at new IntroSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSystemNode.js?bust=1472164900792:112:26)
    at new IntroView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroView.js?bust=1472164900792:65:23)
    at IntroScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/IntroScreen.js?bust=1472164900792:31:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new IntroSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSpringControls.js?bust=1472164900792:53:7)
    at new IntroSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroSystemNode.js?bust=1472164900792:112:26)
    at new IntroView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/view/IntroView.js?bust=1472164900792:65:23)
    at IntroScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/intro/IntroScreen.js?bust=1472164900792:31:34)
    at IntroScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at IntroScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at SystemsVisibilityControls.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new SystemsVisibilityControls (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsVisibilityControls.js?bust=1472164900792:169:11)
    at new SystemsView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsView.js?bust=1472164900792:39:30)
    at SystemsScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/SystemsScreen.js?bust=1472164900792:31:34)
    at SystemsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at SystemsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
    at http://localhost/~cmalley/GitHub/hookes-law/js/hookes-law-main.js?bust=1472164900792:37:15
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new SeriesSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SeriesSpringControls.js?bust=1472164900792:79:7)
    at new SeriesSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SeriesSystemNode.js?bust=1472164900792:143:26)
    at new SystemsView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsView.js?bust=1472164900792:55:28)
    at SystemsScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/SystemsScreen.js?bust=1472164900792:31:34)
    at SystemsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at SystemsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new SeriesSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SeriesSpringControls.js?bust=1472164900792:80:7)
    at new SeriesSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SeriesSystemNode.js?bust=1472164900792:143:26)
    at new SystemsView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsView.js?bust=1472164900792:55:28)
    at SystemsScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/SystemsScreen.js?bust=1472164900792:31:34)
    at SystemsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at SystemsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new ParallelSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/ParallelSpringControls.js?bust=1472164900792:82:7)
    at new ParallelSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/ParallelSystemNode.js?bust=1472164900792:150:26)
    at new SystemsView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsView.js?bust=1472164900792:64:30)
    at SystemsScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/SystemsScreen.js?bust=1472164900792:31:34)
    at SystemsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at SystemsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new ParallelSpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/ParallelSpringControls.js?bust=1472164900792:83:7)
    at new ParallelSystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/ParallelSystemNode.js?bust=1472164900792:150:26)
    at new SystemsView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/view/SystemsView.js?bust=1472164900792:64:30)
    at SystemsScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/systems/SystemsScreen.js?bust=1472164900792:31:34)
    at SystemsScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at SystemsScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at EnergyVisibilityControls.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new EnergyVisibilityControls (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergyVisibilityControls.js?bust=1472164900792:131:11)
    at new EnergyView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergyView.js?bust=1472164900792:39:30)
    at EnergyScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/EnergyScreen.js?bust=1472164900792:31:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
    at http://localhost/~cmalley/GitHub/hookes-law/js/hookes-law-main.js?bust=1472164900792:37:15
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new EnergySpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergySpringControls.js?bust=1472164900792:51:7)
    at new EnergySystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergySystemNode.js?bust=1472164900792:104:26)
    at new EnergyView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergyView.js?bust=1472164900792:47:22)
    at EnergyScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/EnergyScreen.js?bust=1472164900792:31:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
VM21571 Panel.js?bust=1472164900792:53 

>>>> sim relies on align:right
VM21571 Panel.js?bust=1472164900792:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472164900792:50:15)
    at new EnergySpringControls (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergySpringControls.js?bust=1472164900792:52:7)
    at new EnergySystemNode (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergySystemNode.js?bust=1472164900792:104:26)
    at new EnergyView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/view/EnergyView.js?bust=1472164900792:47:22)
    at EnergyScreen.createView (http://localhost/~cmalley/GitHub/hookes-law/js/energy/EnergyScreen.js?bust=1472164900792:31:34)
    at EnergyScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:134:25)
    at EnergyScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472164900792:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472164900792:439:13)
pixelzoom commented 8 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.