search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Bar Graph is no longer centered #56

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

Reported by @kathy-phet in https://github.com/phetsims/phet-io-wrapper-hookes-law-energy/issues/2#issuecomment-396770593:

The Potential Energy graph is appearing to the left hand side, whereas it should be appearing in the middle. It's almost as if the setting is on "Energy Plot" with the actual energy plot hidden. It should be set on radio button "Bar Graph" active, and the potential energy graph in the middle.

I replied:

This is a regression that snuck in when I changed the enumeration that represents the graph selection to something “more phet-io friendly”, where the messages match the labels on the controls. I’ll investigate.

pixelzoom commented 6 years ago

Bug was probably introduced in https://github.com/phetsims/hookes-law/commit/06f62c847d2ee0d1da422a095628833456426ce1.

pixelzoom commented 6 years ago

Fixed in the above commit. @samreid please verify.

pixelzoom commented 6 years ago

I'm going to close this, since it was a trivial fix and is obviously working correctly now.