phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

revise sliders #60

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

These should be the intervals for sliders:

Spring Constant sliders:

Applied Force sliders:

Displacement slider:

pixelzoom commented 6 years ago

The way that various related constants are specified in HookesLawConstants is not at all clear. Revise to use names like SPRING_CONSTANT_THUMB_INTERVAL and SPRING_CONSTANT_TWEAKER_INTERVAL. And have something like ROBOTIC_ARM_DRAG_INTERVAL for displacement controlled by the robotic arm.

pixelzoom commented 6 years ago

I adjusted the slider intervals. But HookesLawConstant.APPLIED_FORCE_DELTA needs attention. It looks like the related option (appliedForceDelta in Spring) was used at one time, but is no longer used (see https://github.com/phetsims/hookes-law/commit/115852b52e3d06988e3b2c719a2751aad986a6db). Can it be deleted? Or is it something that needs to be restored when I address #57 ?

pixelzoom commented 6 years ago

Merging this issue into #57, since this deals with more than just slider and tweaker intervals.