search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

document reentrant Properties #63

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

This is one of the sims identified in phetsims/axon#179 (comment). Document why reentrant: true is needed for various Properties.

pixelzoom commented 6 years ago

Documentation completed. I also removed reentrant: true for 3 Properties where it was not needed.

Closing.

samreid commented 6 years ago

Latest CT is showing:

hookes-law : fuzz : require.js : run
Uncaught Error: Assertion failed: reentry detected, value=0.010000000000000009, oldValue=0.01
Error: Assertion failed: reentry detected, value=0.010000000000000009, oldValue=0.01
    at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/assert/js/assert.js:22:13)
    at NumberProperty._notifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:301:19)
    at NumberProperty.setValueAndNotifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:287:14)
    at NumberProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:230:16)
    at NumberProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/NumberProperty.js?bust=1536013935827:86:30)
    at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/hookes-law/js/common/model/SingleSpringSystem.js?bust=1536013935827:52:40)
    at Emitter.emit2 (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Emitter.js?bust=1536013935827:180:49)
    at NumberProperty._notifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:304:29)
    at NumberProperty.setValueAndNotifyListeners (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:287:14)
    at NumberProperty.set (https://bayes.colorado.edu/continuous-testing/snapshot-1536012017922/axon/js/Property.js?bust=1536013935827:230:16)
Approximately 9/3/2018, 4:00:17 PM
pixelzoom commented 6 years ago

CT errors were also reported in #64, which I've closed as a duplicate.

pixelzoom commented 6 years ago

In https://github.com/phetsims/hookes-law/commit/6445b03e72b294f358875b9d62164343e44a3c22, reentrant: true was accidentally removed from displacementProperty, when I relocated the associated comment. Restored in the above commit.

pixelzoom commented 6 years ago

CT is happy again. Closing.