Memory leak testing for 1.1 release.

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 4 forks source link

Memory leak testing for 1.1 release. #67

Closed pixelzoom closed 2 months ago

pixelzoom commented 5 years ago

For #91.

pixelzoom commented 2 months ago

See memory test for 1.1.0-dev.18 in https://github.com/phetsims/qa/issues/1102#issuecomment-2197507783.

@KatieWoe said:

Memory test looked ok. If there is a leak it is small.

pixelzoom commented 2 months ago

After addressing dev-test issues for https://github.com/phetsims/qa/issues/1102, here is the result of memory testing for the PhET brand. Heap size stablizes at ~96MB, and the heap size was observed to go down twice (Snapshots 7 & 9). So there no indication of any memory leak.

pixelzoom commented 2 months ago

Please verify for https://github.com/phetsims/qa/issues/1104, close if OK.

Nancy-Salpepi commented 2 months ago

There might be a tiny leak. Heap size did go down or stay the same at some points, but it never seemed to stabilize. Snapshots 11 and 12 were taken 10 minutes apart (all others were taken at one minute intervals).

pixelzoom commented 2 months ago

To me, it looks like it stablized ~66 MB. And since it was ony 1.3 MB different after 20 minutes (Snapshot 10 vs 12) then I doubt there's a leak, or at least any leak that we need to address. So I'm not going to do any additional work on memory management and will call this done.