PhET-iO redesign - Githubissues

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 4 forks source link

PhET-iO redesign #69

Open pixelzoom opened 5 years ago

pixelzoom commented 5 years ago

12/13/18 phetio meeting:

publish a dev version with new Studio
work with @arouinfar to review the current instrumentation

pixelzoom commented 5 years ago

Here's a dev version with revised Studio. Note that nothing is currently "featured", so you'll need to select the "All" radio button to explore what's currently instrumented.

https://phet-dev.colorado.edu/html/hookes-law/1.1.0-dev.14/phet-io/

Things to address in this review:

[ ] Is there anything that IS NOT instrumented that should be?
[ ] Is there anything that IS instrumented that should NOT be?
[ ] Which PhET-iO components should be "features?

pixelzoom commented 5 years ago

@arouinfar I don't know what the timeframe or priority is for this issue, but the ball is in your court. Happy to consult with you on this.

arouinfar commented 5 years ago

Thanks @pixelzoom. I've got my hands full with the issues that came out of the Wave Interference dev test, but I'll try to revisit this early next week in case I need to touch base with you.

arouinfar commented 5 years ago

@pixelzoom this issue is still on my radar, but I probably won't get to it until after the Google.org deadline at the end of the month.

pixelzoom commented 5 years ago

Thanks for the update. Like I said, I have no idea what the priority of this issue is. I'm under the impression (but far from certain) that Graphing Quadratics PhET-iO will be completed before this.

pixelzoom commented 4 years ago

In #75, I completed cleanup of the code. As I said in that issue, I did not make any big changes to what was already instrumented, and I did not add any metadata (e.g. phetioFeatured).

This sim is now ready for redesign using Studio. If you encounter any model/view component that does not appear in Studio, please create an issue to have it instrumented.

pixelzoom commented 3 years ago

1/14/2021 PhET-iO meeting:

Ideally @kathy-phet would like this work to be done in 2021. I can proceed with cleaning things up and moving things forward at my discretion. There are currently no milestones for QA and publishing.

FYI @arouinfar @kathy-phet

pixelzoom commented 3 years ago

I reviewed the state of this sim, and apparently I already did cleanup circa August 2019 - see https://github.com/phetsims/hookes-law/issues/69#issuecomment-520043247. The overrides.js file is currently empty, and the sim is ready for redesign using Studio.

Assigned to @arouinfar and @kathy-phet to handle PhET-iO redesign. Please create new GitHub issues for any change requests.

pixelzoom commented 2 years ago

Status for 1/4/2022 quarterly-planning meeting:

Cleanup has been done.
This issue has been assigned to AR & KP for design since 1/21/21.

pixelzoom commented 1 year ago

I realize that there were a bunch of Text nodes that had not been instrumented, so did not link back to their stringProperty. Addressed in the above commits.

arouinfar commented 1 year ago

This simulation is not currently a PhET-iO design priority, unassigning.

pixelzoom commented 3 weeks ago

1.1 (https://github.com/phetsims/hookes-law/issues/91) will not include PhET-iO, so labeling this as deferred.