use AquaRadioButtonGroup

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 4 forks source link

use AquaRadioButtonGroup #76

Closed pixelzoom closed 3 years ago

pixelzoom commented 4 years ago

From phetsims/sun#555, convert this sim to use AquaRadioButtonGroup for phet-io.

Use in place of AquaRadioButton in these 2 places:

[x] SystemsVisibilityControls: This radio button group needs to be disabled when "Spring Force" is unchecked. AquaRadioButtonGroup currently does not support this.

[x] EnergyVisibilityControls: The "Energy" checkbox needs to be associated with the "Force Plot" radio button in the layout. This is not supported by AquaRadioButtonGroup. I could create an AquaRadioButtonGroup, then tack the "Energy" checkbox onto the bottom. But that doesn't feel very robust -- if the order of radio buttons is ever changed, then the "Energy" checkbox will be in the wrong place.

pixelzoom commented 4 years ago

SystemsVisibilityControls is blocked by https://github.com/phetsims/sun/issues/582.

EnergyVisibilityControls is blocked by https://github.com/phetsims/sun/issues/583.

zepumph commented 4 years ago

https://github.com/phetsims/sun/issues/582 has been completed and closed.

pixelzoom commented 4 years ago

SystemVisibilityControls is done in the above commit.

EnergyVisibilityControls is still blocked by phetsims/sun#583.

pixelzoom commented 4 years ago

From https://github.com/phetsims/sun/issues/583#issuecomment-610571992:

More notes from 3/26/20 dev meeting... It was suggested that the problem with BEERS_LAW_LAB/ViewsControl might be resolved by redesigning it. We should certainly consider that. But my opinion is that this is a perfectly valid design, there's nothing wrong with it, and switching to an inferior design to avoid the problem is not a "solution".

This also applies to HOOKES_LAW/EnergyVisibilityControls.

pixelzoom commented 3 years ago

For EnergyVisibilityControls... Since the "Energy" checkbox appears below the radio button group, I decided to convert the radio buttons to use AquaRadioButtonGroup. The "Energy" check box does not appear as a child of the "Force Plot" radio button in the Studio tree, but that seems OK to me -- we'll see if it comes up in PhET-iO redesign #69.

Closing.