phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Add support for dynamic locale #81

Closed pixelzoom closed 2 months ago

pixelzoom commented 1 year ago

This is ~25% completed.

pixelzoom commented 3 months ago

Done. Ready for review when work resumes on this sim.

Nancy-Salpepi commented 2 months ago

For https://github.com/phetsims/qa/issues/1102 and related to https://github.com/phetsims/hookes-law/issues/88, the touch area for the Values checkbox doesn't expand with ?stringTest=dynamic:

Screenshot 2024-06-28 at 7 56 48 AM
Nancy-Salpepi commented 2 months ago

A couple of differences I see when comparing to the published version:

Dev Version vs. Published:

Screenshot 2024-06-28 at 8 30 10 AM Screenshot 2024-06-28 at 8 29 58 AM

Also with ?stringTest=dynamic, the text background of the Applied Force Value can overlap the panel slightly when Displacement =1.

Screenshot 2024-06-28 at 12 06 40 PM
Nancy-Salpepi commented 2 months ago

For https://github.com/phetsims/qa/issues/1102 in locales other than English, the bottom panel sizes are slightly different heights. Here are the Spring and Applied Force panels for the screens 1&2 in Hebrew:

Screenshot 2024-06-28 at 3 36 30 PM Screenshot 2024-06-28 at 3 39 59 PM

And here are the Spring and Displacement panels for screen 3 in Hebrew:

Screenshot 2024-06-28 at 3 48 27 PM
jessegreenberg commented 2 months ago

A couple of notes from https://github.com/phetsims/qa/issues/1102 regarding layout changes, possibly from dynamic locale:

pixelzoom commented 2 months ago

There were a bunch of unrelated issues reported in this issue. To make them easier to verify by QA, I've moved them to their own issues, linked above.