phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Pointer areas are longer than touch areas in many places #88

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 2 months ago

Test device MacBook Air M1 chip

Operating System 14.5

Browser Safari 17.5

Problem description For https://github.com/phetsims/qa/issues/1102, in many places the pointer areas have a greater length than the touch areas. On the Energy Screen it looks like the graph/plot radio buttons have 2 touch areas.

Visuals

Screenshot 2024-06-27 at 9 10 19 PM Screenshot 2024-06-27 at 9 12 50 PM
pixelzoom commented 2 months ago

@Nancy-Salpepi please review, close if OK. Note the decision NOT to right-align icons in https://github.com/phetsims/hookes-law/issues/100.

Intro screen:

screenshot_3394

Systems screen:

screenshot_3395

Energy screen:

screenshot_3396
Nancy-Salpepi commented 2 months ago

The radio button group on the Energy screen still seems to have 2 different touch areas--one that is the same size as the pointer area and a second one that is wider....you can see it in your screenshot but here is a zoomed-in view:

Screenshot 2024-07-02 at 3 32 00 PM
pixelzoom commented 2 months ago

Good eye @Nancy-Salpepi. There was an extra touchArea being added for the radio button group. I've removed it in the above commit, see screenshot below. I'll go ahead and close this issue.

screenshot_3397