search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Increment/Decrement buttons change value at different intervals than published #89

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 2 months ago

Test device MacBook Air M1 chip

Operating System 14.5

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/1102, on all screens the Spring increment/decrement buttons now change the value by 1, whereas in published the value changes by 10. This applies to the Spring Constant, Left/Right Springs and Top/Bottom Springs. The same thing is seen with the Displacement increment/decrement buttons. In 1.1.0-dev.18 the value changes by 0.010 and in published it changes by 0.001.

Steps to reproduce Compare the dev and published versions by

  1. Going to the Energy Screen and pressing the increment/decrement buttons for the Spring Constant
  2. Then pressing the increment/decrement buttons for Displacement

Visuals This video compares the Spring Constant values in dev vs published:

https://github.com/phetsims/hookes-law/assets/87318828/77123bac-c701-48db-8207-b90a96b8021c

Nancy-Salpepi commented 2 months ago

I see now that this was an intentional change made in https://github.com/phetsims/hookes-law/issues/60. Closing.