search

phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Shorter strings can move the images next to them #98

Closed pixelzoom closed 2 months ago

pixelzoom commented 2 months ago

For https://github.com/phetsims/qa/issues/1102 ... From https://github.com/phetsims/hookes-law/issues/81#issuecomment-2198782920 by @jessegreenberg:

Shorter strings can move the images next to them, which didn't happen in published. Both dynamic and non-dynamic locale seems impacted. @Matthew-Moore240 noted it is a little easier to see with ?stringTest=dynamic.

https://github.com/phetsims/hookes-law/assets/8419308/0b44afd3-6031-4109-99e9-a37ffa05376d

pixelzoom commented 2 months ago

@Nancy-Salpepi please review, close if OK. Note the decision NOT to right-align icons in https://github.com/phetsims/hookes-law/issues/100.

Nancy-Salpepi commented 2 months ago

On main, with ?stringTest=dynamic the spacing between the text and icons remains constant.

Also, so not impressed with the title you came up with for this issue 🤣.

Closing