phetsims / hookes-law

"Hooke's Law" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Unwanted icon to the right of "Spring Forces" checkbox #99

Closed pixelzoom closed 2 months ago

pixelzoom commented 2 months ago

For https://github.com/phetsims/qa/issues/1102 ...

In 1.0, the Spring Force checkbox has no icon to the right of it:

screenshot_3390

In main, the Spring Force checkbox now has an icon (blue vector) to the right of it:

screenshot_3389

This seems like a regression, since the purpose of the radio buttons below the Spring Force checkbox is to select the representation of spring force.

@arouinfar To you recall any intentional change related to this, or do you also think this is a regression?

arouinfar commented 2 months ago

@pixelzoom this looks like a regression to me. There shouldn't be an icon next to the Spring Force checkbox when it has nested radio buttons.

pixelzoom commented 2 months ago

Thanks @arouinfar. Icon has been removed. Closing.